Clarify IContextMenu::QueryContextMenu return value #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is very unhelpful to use 5 for both idCmdFirst and the menu id in the example.
|
@whindsaks : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
whindsaks
changed the title
|
There should probably also be a note somewhere that some shell extensions just return a count of items it added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very unhelpful to use 5 for both idCmdFirst and the menu id in the example!
I don't guarantee that my understanding of this calculation is correct. Please ask Raymond Chen to verify if the -5 in the example is supposed to be idCmdFirst or the lowest menu id.